Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plug: inline namespace, cleanup, build UI earlier #166

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Plug: inline namespace, cleanup, build UI earlier #166

merged 3 commits into from
Jan 3, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jan 1, 2024 •
edited
Loading

Review with hide whitespace changes

  • No reason for each view to be public static anymore
  • Build UI in get_widget prevents blank UI during navigation animation
  • Code style
  • Box instead of grid
  • Pass a ref to permission instead of public static

@danirabbit danirabbit changed the title Danirabbit/plug cleanup Plug: inline namespace, cleanup, build UI earlier Jan 1, 2024
@danirabbit danirabbit force-pushed the danirabbit/plug-cleanup branch from bc53a34 to f9d9b13 Compare January 3, 2024 20:46
@danirabbit danirabbit marked this pull request as ready for review January 3, 2024 21:09
@danirabbit danirabbit requested a review from a team January 3, 2024 21:09
Marukesu
Marukesu reviewed Jan 3, 2024
View reviewed changes
src/Plug.vala Show resolved Hide resolved
src/Plug.vala Outdated Show resolved Hide resolved
src/Plug.vala Outdated Show resolved Hide resolved
@danirabbit danirabbit mentioned this pull request Jan 3, 2024
Merged
@danirabbit danirabbit requested a review from Marukesu January 3, 2024 21:52
@danirabbit danirabbit merged commit aa07fa3 into master Jan 3, 2024
4 checks passed
@danirabbit danirabbit deleted the danirabbit/plug-cleanup branch January 3, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marukesu Marukesu Marukesu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @Marukesu