Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FirewallPanel: GTK 4 prep, cleanup #167

Merged
merged 5 commits into from
Jan 3, 2024
Merged

FirewallPanel: GTK 4 prep, cleanup #167

merged 5 commits into from
Jan 3, 2024

Conversation

danirabbit
Copy link
Member

  • Use switch statements instead of multiple if/else
  • construct with properties
  • other code style
  • Box instead of Grid
  • Use child property
  • Explicit expands and margins
  • Set mnemonic widgets for label for screen reader

@danirabbit danirabbit requested a review from a team January 1, 2024 23:59
@danirabbit danirabbit mentioned this pull request Jan 3, 2024
Merged
@danirabbit danirabbit merged commit 45a6681 into master Jan 3, 2024
4 checks passed
@danirabbit danirabbit deleted the danirabbit/firewallpanel-gtk4 branch January 3, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marukesu Marukesu Marukesu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GTK4 Porting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @Marukesu