Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrackPanel: make clear history a dialog #168

Merged
merged 4 commits into from
Jan 3, 2024
Merged

TrackPanel: make clear history a dialog #168

merged 4 commits into from
Jan 3, 2024

Conversation

danirabbit
Copy link
Member

Screenshot from 2024-01-02 12 37 12

This should be done in a dialog instead of a popover

  • Consistently use the words "Clear" and "History" throughout
  • Explicit "Cancel"
  • Explain consequences of actions

@danirabbit danirabbit requested a review from a team January 2, 2024 20:37
jeremypw
jeremypw approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works as expected

@jeremypw jeremypw enabled auto-merge (squash) January 3, 2024 18:20
@jeremypw jeremypw merged commit 80083f8 into master Jan 3, 2024
4 checks passed
@jeremypw jeremypw deleted the danirabbit/clearhistorydialog branch January 3, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @jeremypw