Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use meson build system #75

Merged
merged 6 commits into from
Jul 27, 2018
Merged

Use meson build system #75

merged 6 commits into from
Jul 27, 2018

Conversation

tintou
Copy link
Member

@tintou tintou commented Jul 26, 2018 •
edited
Loading

I tried to keep everything 1:1 from CMake, please review carefully

Fixes #62

@tintou tintou force-pushed the tintou/meson branch 5 times, most recently from aefae7c to 61412a8 Compare July 26, 2018 15:22
danirabbit
danirabbit previously requested changes Jul 26, 2018
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the value for plugsdir is incorrect. It's trying to load plugs from /usr/share/switchboard instead of /usr/lib/x86_64-linux-gnu/switchboard/

@tintou tintou dismissed danirabbit’s stale review July 26, 2018 15:59

Doh! fixed :)

@tintou tintou force-pushed the tintou/meson branch 3 times, most recently from 39cc813 to 7722b18 Compare July 26, 2018 16:09
danirabbit
danirabbit previously requested changes Jul 26, 2018
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles, but the metadata files still have _ characters from the CMake translations so they're not properly translated with Meson

@danirabbit
Copy link
Member

danirabbit commented Jul 26, 2018 •
edited
Loading

After installing the lib, I'm getting some errors loading plugs. It sounds like all the plugs are expecting libswitchboard-2.0.so.0 but this is building libswitchboard-2.0.so.2.0 with a symlink for libswitchboard-2.0.so.2. Is that intentional and we'll need to rebuild all the plugs or a mistake?

@tintou
Copy link
Member Author

tintou commented Jul 26, 2018

@danrabbit fixed, for some reason, the soversion is 0 when the full version is 2.0…

danirabbit
danirabbit approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that everything works as expected when built and installed from packaging. Nice work :)

@danirabbit danirabbit requested a review from codygarver July 26, 2018 18:39
@codygarver codygarver merged commit cd4124e into master Jul 27, 2018
@codygarver codygarver deleted the tintou/meson branch July 27, 2018 08:23
@danirabbit danirabbit mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

@codygarver codygarver codygarver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tintou @danirabbit @codygarver