Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EditableLabel: Gtk4 Prep #383

Merged
merged 3 commits into from
Jun 5, 2024
Merged

EditableLabel: Gtk4 Prep #383

merged 3 commits into from
Jun 5, 2024

Conversation

danirabbit
Copy link
Member

  • Use Event Controllers
  • We already have a good hover indicator for an editable item: the cursor. Remove the button revealer and use cursor
  • Code style
  • grab_focus isn't a signal in GTK 4

@danirabbit danirabbit requested a review from a team May 16, 2024 18:54
ryonakano
ryonakano approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and working as expected.

@danirabbit danirabbit merged commit 5d4a035 into master Jun 5, 2024
6 checks passed
@danirabbit danirabbit deleted the danirabbit/editablelabel-gtk4prep branch June 5, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryonakano ryonakano ryonakano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GTK4 Porting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danirabbit @ryonakano @zeebok