Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EntryPopover/Generic: Gtk4 Prep #386

Merged
merged 4 commits into from
Jun 10, 2024
Merged

EntryPopover/Generic: Gtk4 Prep #386

merged 4 commits into from
Jun 10, 2024

Conversation

danirabbit
Copy link
Member

  • Use motion controller
  • Construct button contents in GTK4 friendly way
  • Code style
  • use child property

@danirabbit danirabbit requested a review from a team June 6, 2024 22:07
@danirabbit danirabbit requested a review from ryonakano June 10, 2024 19:09
ryonakano
ryonakano approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected!

@danirabbit danirabbit merged commit 58cfb39 into master Jun 10, 2024
6 checks passed
@danirabbit danirabbit deleted the danirabbit/entrypopover-generic-gtk4prep branch June 10, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryonakano ryonakano ryonakano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GTK4 Porting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @ryonakano