Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly open uris containing spaces #777

Merged
merged 6 commits into from
Nov 4, 2024

Conversation

jeremypw
Copy link
Collaborator

Fixes #775

@teamcons
Copy link
Contributor

Any ETA for merging this bugfix ? The PR seems stale

@jeremypw jeremypw requested a review from a team November 1, 2024 10:12
src/Widgets/TerminalWidget.vala Outdated Show resolved Hide resolved
src/Widgets/TerminalWidget.vala Outdated Show resolved Hide resolved
@jeremypw
Copy link
Collaborator Author

jeremypw commented Nov 3, 2024

@ryonakano Thanks for the review. I have now addressed your comments.

@jeremypw jeremypw requested a review from ryonakano November 3, 2024 12:54
@teamcons
Copy link
Contributor

teamcons commented Nov 4, 2024

YES
Thank you !!!!

@jeremypw jeremypw merged commit b946a89 into master Nov 4, 2024
4 checks passed
@jeremypw jeremypw deleted the jeremypw/fix-openterminalhere-2 branch November 4, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Open in Terminal" menu option in Files does not work correctly when uri contains spaces
3 participants