Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Clear and Reset actions with hotkeys #778

Merged
merged 7 commits into from
Oct 6, 2024

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Sep 2, 2024

Fixes #181 (?)

I am unsure whether the Clear action should also clear the scrollback buffer. At the moment it does not because the "Reset" action does that. The native hotkey <Control>L does not clear the buffer but typing clear into the terminal does.

Is it worth implementing two actions - "Clear Screen Only" and "Clear Screen and Scrollback"?

The XFCE terminal labels the reset action "Clear Scrollback and Reset" - should we follow or is that too verbose?

Should the "Clear Screen" menu option be labelled "Clear Screen Only"?

@jeremypw jeremypw requested a review from a team September 2, 2024 17:18
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. To me this resolves what they were asking for, though it does make me curious what was handling the CTRL + L shortcut before this?

@jeremypw
Copy link
Collaborator Author

jeremypw commented Oct 6, 2024

Lets merge and refine with further PRs if required.

@jeremypw jeremypw merged commit 2dc7e2e into master Oct 6, 2024
4 checks passed
@jeremypw jeremypw deleted the jeremypw/expose-clearscreen branch October 6, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support clearing the screen mid process (Reset + Clear)
2 participants