Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gtk4Prep - Handle restoring and syncing window state in Application #783

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Gtk4Prep - Handle restoring and syncing window state in Application #783

merged 6 commits into from
Sep 5, 2024

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Sep 5, 2024

  • Gtk4 Does not have configure-event
  • Follow pattern of Icon Browser (Gtk4) with regards to settings
  • Restore saved state function can just be deleted on porting
  • Replaced by settings binding to window properties.

danirabbit
danirabbit requested changes Sep 5, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment otherwise looks good

src/Application.vala Outdated Show resolved Hide resolved
@danirabbit danirabbit merged commit 32ff88e into master Sep 5, 2024
4 checks passed
@danirabbit danirabbit deleted the jeremypw/lose-configure-event branch September 5, 2024 21:26
jeremypw pushed a commit that referenced this pull request Dec 14, 2024
Revert "Gtk4Prep - Handle restoring and syncing window state in Appli…
6b5a6ef 
…cation (#783)"

This reverts commit 32ff88e.
jeremypw added a commit that referenced this pull request Dec 15, 2024
@jeremypw
Revert "Gtk4Prep - Handle restoring and syncing window state in App (#…
38b731d 
…822)

* Revert "Gtk4Prep - Handle restoring and syncing window state in Application (#783)"

This reverts commit 32ff88e.

* New window follows current window size

---------

Co-authored-by: Jeremy Wootten <jeremy@Proteus-EL07R6-9b3c42bb.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremypw @danirabbit