Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SettingsPopover: use provider_for_screen for theme buttons #785

Merged
merged 5 commits into from
Sep 8, 2024

Conversation

danirabbit
Copy link
Member

GTK4 prep. Adding a provider to a widget is deprecated. Also, in Gtk4 adding a provider to a context doesn't add it to the children of the context, so this was broken

@danirabbit danirabbit requested a review from jeremypw September 5, 2024 20:39
@danirabbit danirabbit requested a review from jeremypw September 6, 2024 21:10
@danirabbit
Copy link
Member Author

Fixed! Dunno why I thought theme was an object and not a string here but this seems to work perfectly

@jeremypw jeremypw merged commit 1d9cdf6 into master Sep 8, 2024
4 checks passed
@jeremypw jeremypw deleted the danirabbit/settingspopover-providerforscreen branch September 8, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants