Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Style - #790

Merged
merged 6 commits into from
Sep 16, 2024
Merged

Code Style - #790

merged 6 commits into from
Sep 16, 2024

Conversation

jeremypw
Copy link
Collaborator

Small changes in code style of some constructors to more closely follow elementary code style.

  • Use construct block
  • Move assignments out of constructor function into construction block where possible

@jeremypw jeremypw requested a review from a team September 15, 2024 15:20
@danirabbit danirabbit enabled auto-merge (squash) September 15, 2024 15:30
@danirabbit danirabbit merged commit 1a6b46b into master Sep 16, 2024
4 checks passed
@danirabbit danirabbit deleted the jeremypw/code-style-construct branch September 16, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremypw @danirabbit