Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application: withdraw stale notifications #813

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Application: withdraw stale notifications #813

merged 4 commits into from
Dec 4, 2024

Conversation

danirabbit
Copy link
Member

Fixes #812

@danirabbit danirabbit marked this pull request as ready for review November 29, 2024 20:33
@danirabbit danirabbit requested a review from a team November 29, 2024 20:33
@lenemter
Copy link
Member

@danirabbit we don't support withdrawing notifications yet, do we? elementary/wingpanel-indicator-notifications#204

@danirabbit
Copy link
Member Author

@lenemter we do, but it doesn't work across sessions yet. So if you restart in between it won't get cleared because the notification IDs I think aren't restored

@jeremypw
Copy link
Collaborator

jeremypw commented Dec 4, 2024

Shouldn't we remove the "process-completed" tab icon as well when tab is focussed?

@jeremypw
Copy link
Collaborator

jeremypw commented Dec 4, 2024 •
edited
Loading

@danirabbit Works within same session. Not sure if you want to fix the icon issue, which is kind of related, in this PR or later. Do you want to wait for cross-session ability too? I am willing to approve if not.

jeremypw
jeremypw approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to approve this as within session functionality is still an improvement

@danirabbit danirabbit merged commit c5cfbcd into master Dec 4, 2024
4 checks passed
@danirabbit danirabbit deleted the danirabbit/notify-withdraw branch December 4, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notifications are not withdrawn
3 participants
@danirabbit @lenemter @jeremypw