Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JS Lint Warnings #3448

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Fix JS Lint Warnings #3448

merged 4 commits into from
Jul 25, 2024

Conversation

lewisgoddard
Copy link
Member

Fixes the warnings that appear in the lint logs due to old style var usage over let or const for variable assignment.

This pull request is ready for review.

@lewisgoddard
Copy link
Member Author

Previous run with warnings in CI annotations: https://github.com/elementary/website/actions/runs/7532773670
New run without warnings from this branch: https://github.com/elementary/website/actions/runs/7545597357

@lewisgoddard lewisgoddard requested review from a team and removed request for davidmhewitt July 23, 2024 09:36
@RMcNeely RMcNeely added the Outdated Issue is no longer valid label Jul 24, 2024
@lewisgoddard lewisgoddard removed the Outdated Issue is no longer valid label Jul 25, 2024
@lewisgoddard lewisgoddard enabled auto-merge (squash) July 25, 2024 01:58
@lewisgoddard lewisgoddard merged commit f136443 into master Jul 25, 2024
5 checks passed
@lewisgoddard lewisgoddard deleted the fix-js-lint-warnings branch July 25, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMcNeely RMcNeely RMcNeely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewisgoddard @RMcNeely