Fix job queueing when a post is saved or trashed. #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression introduced in 09847fd, but rather than simply revert the relevant changes made there, I opted to move the calls to CoreOptions::getValue into the handlers, so they will only hit the DB when the hooks fire, rather than potentially every page load.
savePosted is normally called only when the Options page is POSTed, so the add_action calls aren't any use here.
|
Beautiful, thanks @john-shaffer! I'm unable to do an end to end test right now, but looks good and better than broken! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in 09847fd,
but rather than simply revert the relevant changes made there, I opted to
move the calls to CoreOptions::getValue into the handlers, so they will
only hit the DB when the hooks fire, rather than potentially every page load.
Fixes #544.