Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem on MySQL syntax of 'IF EXISTS' #848

Closed
wants to merge 3 commits into from
Closed

Fix the problem on MySQL syntax of 'IF EXISTS' #848

wants to merge 3 commits into from

Conversation

utchy
Copy link
Contributor

@utchy utchy commented Feb 14, 2022

Fixes #847

I fixed the issue without using the information_schema in case for a db user who is not able to access it.

@leonstafford
Copy link
Contributor

Thanks @utchy! Approved the CI tests to run and will merge it in after they've completed.

@leonstafford
Copy link
Contributor

@utchy would it be possible to also get https://github.com/naturalplants/wp2static/pull/5/files as a PR?

@utchy
Copy link
Contributor Author

utchy commented Feb 15, 2022

@leonstafford
Thanks for approving the request!

would it be possible to also get https://github.com/naturalplants/wp2static/pull/5/files as a PR?

Sure! I'll cherry-pick the changes and include it in this PR.

@utchy
Copy link
Contributor Author

utchy commented Feb 17, 2022

@leonstafford Please check the additional commit to support multisite.

john-shaffer pushed a commit to john-shaffer/wp2static that referenced this pull request Feb 18, 2022
@john-shaffer
Copy link
Contributor

Merged in as 8ed46aa and 00582cf.

Thank you, @utchy!

@utchy utchy deleted the fix/847-mysql-syntax-error-by-if-exists branch March 10, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MySQL syntax error thrown by IF EXISTS when dropping column for description & label
3 participants