Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parser): adds CDATA nodes support #13

Merged
merged 6 commits into from
Mar 4, 2024
Merged

feat(parser): adds CDATA nodes support #13

merged 6 commits into from
Mar 4, 2024

Conversation

Suero152
Copy link
Contributor

Solves #11.

@elenakrittik elenakrittik linked an issue Mar 1, 2024 that may be closed by this pull request
<![CDATA[ ]]> Is being ignored and do not appear as a content #11
Closed
elenakrittik
elenakrittik requested changes Mar 1, 2024
View reviewed changes
Copy link
Owner

@elenakrittik elenakrittik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the fix! The issue you opened somehow didn't appear in my notifications inbox, so i missed it :(

addons/godot_xml/xml.gd Outdated Show resolved Hide resolved
addons/godot_xml/xml.gd Outdated Show resolved Hide resolved
addons/godot_xml/xml.gd Outdated Show resolved Hide resolved
@elenakrittik elenakrittik added the pr: bug A PR that fixs a bug. label Mar 1, 2024
@elenakrittik
Copy link
Owner

Oh, and also, don't forget about including CDATA contents when converting to dictionaries!

@Suero152
Copy link
Contributor Author

Suero152 commented Mar 2, 2024

Made the changes that you requested. I wonder if _dump and _dump_pretty funcs shouldn't be refactored too?

elenakrittik
elenakrittik requested changes Mar 3, 2024
View reviewed changes
Copy link
Owner

@elenakrittik elenakrittik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes that you requested. I wonder if _dump and _dump_pretty funcs shouldn't be refactored too?

Thanks, correct, these need to be updated as well! You'll need to iterate over elements of XMLNode.cdata and for each element add a corresponding CDATA node

addons/godot_xml/xml.gd Outdated Show resolved Hide resolved
addons/godot_xml/xml.gd Outdated Show resolved Hide resolved
addons/godot_xml/xml_node.gd Outdated Show resolved Hide resolved
addons/godot_xml/xml_node.gd Outdated Show resolved Hide resolved
@Suero152
Copy link
Contributor Author

Suero152 commented Mar 4, 2024

I've made some changes, check if its everything correct. Also, sorry for leaving some errors on the first review request commit, I coded it really bad 😓

elenakrittik
elenakrittik approved these changes Mar 4, 2024
View reviewed changes
Copy link
Owner

@elenakrittik elenakrittik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested things locally, fixed a few things, looks good to me now. Thank you!

@elenakrittik elenakrittik merged commit 530b96c into elenakrittik:master Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenakrittik elenakrittik elenakrittik approved these changes

Assignees
No one assigned
Labels
pr: bug A PR that fixs a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<![CDATA[ ]]> Is being ignored and do not appear as a content
2 participants
@Suero152 @elenakrittik