Fix unnecessary unescaping

[Kiisu-Master]

I removed the unnecessary unescaping.
It is already done by Godots xml parser and the addition of this leads to double unescaping.

I noticed the strip_edges also modifies content in unwanted ways but when i remove it, it breaks...

[elenakrittik]

Thanks, i didn't even think Godot may've done that by itself! Looking through the sources it indeed calls .xml_unescape() when parsing.

I noticed the strip_edges also modifies content in unwanted ways but when i remove it, it breaks...

Can you elaborate? The .strip_edges() calls were always there, in that commit i only removed .lstrip() and .rstrip() calls because .strip_edges() already stripped spaces, so these unwanted changes must've been there before the commit too?

[Kiisu-Master]

I noticed the strip_edges also modifies content in unwanted ways but when i remove it, it breaks...

Can you elaborate? The .strip_edges() calls were always there, in that commit i only removed .lstrip() and .rstrip() calls because .strip_edges() already stripped spaces, so these unwanted changes must've been there before the commit too?

Yes the strip_edges problem was already there before. I only noticed it now because I was looking at your changes on the same line.

The problem is that when you have a node with content that has spaces, these spaces will get removed from the edges when parsing. This means the content is not the same after dumping and parsing.

I don't have ideas how to fix it though. Reading the comment, it seems like a workaround for a Godot xml parser problem?

[elenakrittik]

The problem is that when you have a node with content that has spaces, these spaces will get removed from the edges when parsing.

Yep, that's intentional (but can be reverted, of course). I did it because i don't think that with, e.g.:

<node>
  Hello!
</node>

..one would expected the content to be "\n Hello!\n". At the same time i recognize that this practically forbids you from having multiline content, but that's an intentional trade-off i made in my mind when i've written it. Personally, my rule of thumb is "single-line data => make it an attribute; multi-line data => make it a CDATA", but i'm always open to feedback and we can change that (under an option).

Reading the comment, it seems like a workaround for a Godot xml parser problem?

In this case, it's more of an "unwanted" thing than an "issue" (the _cleanup_double_blankets() function below does exist to workaround an issue, but i assume that's out of your concern?).

[elenakrittik]

I'm going to merge this and open a separate issue for the "blank space problem". Thanks!