Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

CallExecutor does not know the type of a result #72

Closed
dev3loperb opened this issue Aug 10, 2018 · 2 comments
Closed

CallExecutor does not know the type of a result #72

dev3loperb opened this issue Aug 10, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@dev3loperb
Copy link
Contributor

Why when I need to pass a callback to CallExecutor#onSuccess, I need to pass a RetryListener which does not know anything about the type of Status which it uses in onEvent method?

dev3loperb added a commit to dev3loperb/retry4j that referenced this issue Aug 10, 2018
@elennick elennick assigned elennick and dev3loperb and unassigned elennick Aug 10, 2018
@elennick elennick added the bug label Aug 10, 2018
@elennick elennick added this to the 0.15.0 milestone Aug 10, 2018
dev3loperb added a commit to dev3loperb/retry4j that referenced this issue Aug 10, 2018
Add a test for AsyncCallExecutor to test listeners
Use assertions for a test of CallExecutor
dev3loperb added a commit to dev3loperb/retry4j that referenced this issue Aug 10, 2018
Return the version of pom back to 0.15.0-SNAPSHOT
dev3loperb added a commit to dev3loperb/retry4j that referenced this issue Aug 10, 2018
Get rid of redundant testing - simplify test cases
dev3loperb added a commit to dev3loperb/retry4j that referenced this issue Aug 10, 2018
Avoid dependency on any mock for tests of a result type
elennick added a commit that referenced this issue Aug 10, 2018
PR for CallExecutor does not know the type of a result #72
@elennick
Copy link
Owner

Thanks for the PR... I can do a release with this fix tonight. It will probably be 0.15.0.

@elennick
Copy link
Owner

fixed in release 0.15.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants