feat(mint): distribute developer and community funds #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables distribution of 2*10% off the newly-minted tokens to the x/distribution community pool, and the developer funding pool. The developer funding pool is represented as a standard Cosmos address, which should be determined at genesis time.
noandrea
added
the
cascading
noandrea
reviewed
Jun 30, 2022
| // send the minted coins to the fee collector account | ||
| // calculate 10% off mintedCoins | ||
| // this is handled in sdk.Ints already, some rounding error might persist. | ||
| tenPercentRawAmt := mintedCoin.Amount.MulRaw(10).QuoRaw(100) |
There was a problem hiding this comment.
shall we do it every block or once at the beginning of the year?
There was a problem hiding this comment.
Hmm, like a lookup map?
I would just do this every block, in the end it's a very simple math operation --- even on big.Ints it's no big deal.
noandrea
approved these changes
Jun 30, 2022
gsora
added a commit
that referenced
this pull request
Jun 30, 2022
* fix(app): make sure to signal ica host and credential module addition * feat(mint): add burning caps * feat(mint): add migration to fix utsp param denom error * chore(mint): don't fix the wrong stake tokens issue This migration will just replace the mint denom * chore(mint): make golangci-lint happy * chore(mint): fix tests * chore(mint): revert back to generic "stake" denom We configure "utsp" via manual genesis.json editing. The migration still writes "utsp" because it's fixing our bad behavior (we should've edited the genesis). * chore(mint): remove method impl for Burn interface * feat(mint): distribute developer and community funds (#167) * fix: disable CGO for node builds * feat(devnet): adding script to spin up local devnet (#160) * feat(mint): distribute developer and community funds This commit enables distribution of 2*10% off the newly-minted tokens to the x/distribution community pool, and the developer funding pool. The developer funding pool is represented as a standard Cosmos address, which should be determined at genesis time. Co-authored-by: Andrea Giacobino <no.andrea@gmail.com> Co-authored-by: PaddyMc <paddymchale@hotmail.com> Co-authored-by: Andrea Giacobino <no.andrea@gmail.com> Co-authored-by: PaddyMc <paddymchale@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables distribution of 2*10% off the newly-minted tokens
to the x/distribution community pool, and the developer funding pool.
The developer funding pool is represented as a standard Cosmos address,
which should be determined at genesis time.
Closes #107.