-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Most recent release as sent to Google Play #891
Open
Grunthos
wants to merge
25
commits into
eleybourn:master
Choose a base branch
from
Grunthos:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Huge collection of changes to support builting scanner, API 33 and remove all of the LibraryThing and goodreads support (both have disabled their APIs). Lots of changes: - Builtin scanner - Use system file chooser to backups and export - removal of old file chooser/saver code - removal of goodread - removal of LibraryThing - removal of old preferences - probably more
- is passed a DocumentFile or open stream, so no need - for some reason the check fails on a small number of phones
- Was creating bogus file names with duplicated prefixes - Was creating a file to test writability and could use .isWritable() instead - backupDbFile now returns a File object so callers need not understand location algorithm
…message displays, added uses-feature (camera) to manifest In retrospect this was not the ideal way to perform special upgrad steps. A better approach would have been to create a whole new activity to function as a dialog. That activity would manage the upgrade and THEN start the main activity. This has the advantage of an arms-length approach from the main app functions and thus would rely less on 'standard' app features (and interfere with them less).
…messes with activity creation We REALLY need a better startup process to capture all the random stuff requiring user interaction that needs to happen from time to time
Note: Google don't like ProgressDialog and it now has warnings. The say Modal is bad. So, some time in the future we will have to roll our own because modal is SOMETIMES necessary, ffs. eg. when upgrading the app.
- We use it for error reporting and tech suport purposes
…ings every time a new translator is added - In the process got translations for 'a_and_b'
…om <= 206 - Changed hint manager to allow hints to have default value for isVisible - Added hidden preference for checking for missing covers - Added startup task to check for missing covers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.