Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most recent release as sent to Google Play #891

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

Grunthos
Copy link
Collaborator

No description provided.

Grunthos added 25 commits May 6, 2023 23:20
Huge collection of changes to support builting scanner, API 33 and remove all of the LibraryThing and goodreads support (both have disabled their APIs).

Lots of changes:

- Builtin scanner
- Use system file chooser to backups and export
- removal of old file chooser/saver code
- removal of goodread
- removal of LibraryThing
- removal of old preferences
- probably more
- is passed a DocumentFile or open stream, so no need
- for some reason the check fails on a small number of phones
- Was creating bogus file names with duplicated prefixes
- Was creating a file to test writability and could use .isWritable() instead
- backupDbFile now returns a File object so callers need not understand location algorithm
…message displays, added uses-feature (camera) to manifest

In retrospect this was not the ideal way to perform special upgrad steps. A better approach would have been to create a whole new activity to function as a dialog. That activity would manage the upgrade and THEN start the main activity. This has the advantage of an arms-length approach from the main app functions and thus would rely less on 'standard' app features (and interfere with them less).
…messes with activity creation

We REALLY need a better startup process to capture all the random stuff requiring user interaction
that needs to happen from time to time
Note: Google don't like ProgressDialog and it now has warnings. The say Modal is bad. So, some time in the future we will have to roll our own because modal is SOMETIMES necessary, ffs. eg. when upgrading the app.
- We use it for error reporting and tech suport purposes
…ings every time a new translator is added

- In the process got translations for 'a_and_b'
…om <= 206

- Changed hint manager to allow hints to have default value for isVisible
- Added hidden preference for checking for missing covers
- Added startup task to check for missing covers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant