Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incsrch] Cleanup windows stuff #2338

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Conversation

rampitec
Copy link
Contributor

@rampitec rampitec commented Aug 9, 2024

Remove files not directly related to far2l build.
Add Belorussion lng to cmake, thanks for contribution.

Remove files not directly related to far2l build.
Add Belorussion lng to cmake, thanks for contribution.
@elfmz
Copy link
Owner

elfmz commented Aug 12, 2024

But why incsrch/gpl.txt also removed?

@rampitec
Copy link
Contributor Author

But why incsrch/gpl.txt also removed?

I just noticed this is the only plugin having it. Do you want me to restore it?

It might be not needed in the plugin direcory, but this is
not a 'windows stuff'.
@elfmz
Copy link
Owner

elfmz commented Aug 13, 2024

yep its a kind of things to be better kept unless negotiated with original author(s)

@elfmz elfmz merged commit 8557dd7 into elfmz:master Aug 13, 2024
2 checks passed
@rampitec
Copy link
Contributor Author

yep its a kind of things to be better kept unless negotiated with original author(s)

Well, I am the original author ;) But I am OK anyway.

@rampitec rampitec deleted the incsrch-cleanup branch August 13, 2024 09:31
@elfmz
Copy link
Owner

elfmz commented Aug 13, 2024

ah:) then its (would be) ok

@rampitec
Copy link
Contributor Author

ah:) then its (would be) ok

Do you want me to add a separate change to remove it? I really do no want it to differ from general far2l licensing. The purpose it's there was to say: this stuff is free. I think far2l already has a copy for GPL license, although somewhere in the debian packaging, but it is still there. I am OK either way, just want to minimize source clutter.

@elfmz
Copy link
Owner

elfmz commented Aug 13, 2024

yes, as you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants