feat: Add model selection support for Anthropic handler #124 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Anthropic handler currently uses a hardcoded model (claude-3-opus-20240229). This change allows model selection through configuration, matching the behavior of the OpenAI handler. Changes: - Remove hardcoded model string - Use config loader to get model name from configuration - Update model settings initialization
|
Hi @eli64s, hope you are getting a good time. This pr is quite simple and will help a lot to those how wants to custom Anthropic usage on the tool. Can you give a quick view? Only 2 lines of code, promise. |
|
@diekotto Awesome, good catch! Reviewing now. |
|
@diekotto Looks like a unit test failed for the anthropic handler: FAILED tests/models/test_anthropic.py::test_make_request_api_error - Failed: DID NOT RAISE <class 'tenacity.RetryError'>
FAILED tests/models/test_anthropic.py::test_make_request_success - AssertionError: assert ('index', '<code>❯ REPLACE-ME</code>') == ('index', 'Generated text')
At index 1 diff: '<code>❯ REPLACE-ME</code>' != 'Generated text'
Full diff:
(
'index',
- 'Generated text',
+ '<code>❯ REPLACE-ME</code>',
)
FAILED tests/models/test_anthropic.py::test_build_payload - AttributeError: 'AnthropicHandler' object has no attribute 'model'Can you check this out? |
|
Yes, working on it. |
diekotto
force-pushed
the
feat/anthropic-model-selection
branch
from
fe4f7d2 to
8abe727
Compare
|
@eli64s ready. The constructor of the handler don't create the client if the api key is not present. |
|
Results (49.07s):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Anthropic handler currently uses a hardcoded model (claude-3-opus-20240229). This change allows model selection through configuration, matching the behavior of the OpenAI handler.
Changes:
Fixes #124