Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!!!][FEATURE] Introduce Config API #333

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

eliashaeussler
Copy link
Owner

@eliashaeussler eliashaeussler commented Feb 22, 2024

This PR introduces a new Config API. It allows to configure cache warmup options by external config files. Currently supported formats are php, json and yaml/yml. The config file can be as --config option to the cache warmup command.

@eliashaeussler eliashaeussler added the enhancement New feature or request label Feb 22, 2024
@eliashaeussler eliashaeussler self-assigned this Feb 22, 2024
src/Config/CacheWarmupConfig.php Show resolved Hide resolved
src/Config/CacheWarmupConfig.php Outdated Show resolved Hide resolved
src/Config/CacheWarmupConfig.php Show resolved Hide resolved
src/Config/CacheWarmupConfig.php Show resolved Hide resolved
Copy link

codeclimate bot commented Feb 22, 2024

Code Climate has analyzed commit 55076c7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 84.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.8% (-3.7% change).

View more on Code Climate.

@coveralls
Copy link
Collaborator

coveralls commented Feb 22, 2024

Pull Request Test Coverage Report for Build 8441486343

Details

  • 350 of 415 (84.34%) changed or added relevant lines in 18 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.8%) to 93.889%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Config/Option/ExcludePattern.php 19 20 95.0%
src/Helper/ArrayHelper.php 12 14 85.71%
src/Config/CacheWarmupConfig.php 65 127 51.18%
Totals Coverage Status
Change from base Build 8036476957: -3.8%
Covered Lines: 1398
Relevant Lines: 1489

💛 - Coveralls

@eliashaeussler eliashaeussler force-pushed the feature/config-api branch 4 times, most recently from 5edd656 to ca3e396 Compare February 22, 2024 21:17
@eliashaeussler eliashaeussler force-pushed the feature/config-api branch 6 times, most recently from 7f47d89 to 6a385c8 Compare February 25, 2024 08:29
@eliashaeussler eliashaeussler force-pushed the feature/config-api branch 4 times, most recently from d3049e3 to 8892abe Compare March 3, 2024 08:14
@eliashaeussler eliashaeussler changed the title [FEATURE] Introduce Config API [!!!][FEATURE] Introduce Config API Mar 21, 2024
@eliashaeussler eliashaeussler added the breaking This introduces a breaking change label Mar 21, 2024
@eliashaeussler eliashaeussler marked this pull request as ready for review March 26, 2024 19:13
@eliashaeussler eliashaeussler changed the base branch from main to 3.x March 26, 2024 19:13
@eliashaeussler eliashaeussler merged commit e1c164b into 3.x Mar 26, 2024
15 of 17 checks passed
@eliashaeussler eliashaeussler deleted the feature/config-api branch March 26, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This introduces a breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants