Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Populate id in event streams #5

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

eliashaeussler
Copy link
Owner

This PR adds a new method getId() to both event streams. With these methods in place, event streams now populate the internal stream id.

@eliashaeussler eliashaeussler added the maintenance Code base is being maintained label Aug 11, 2023
@eliashaeussler eliashaeussler self-assigned this Aug 11, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 11, 2023

Code Climate has analyzed commit 9e6eab0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2060f28) 100.00% compared to head (9e6eab0) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main        #5   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        37        39    +2     
===========================================
  Files              6         6           
  Lines            109       113    +4     
===========================================
+ Hits             109       113    +4     
Files Changed Coverage Δ
src/Stream/Psr7EventStream.php 100.00% <100.00%> (ø)
src/Stream/SelfEmittingEventStream.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eliashaeussler eliashaeussler merged commit 5c66a7e into main Aug 11, 2023
10 checks passed
@eliashaeussler eliashaeussler deleted the task/populate-id branch August 11, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code base is being maintained
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant