Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!!!][TASK] Drop TypeTransformerInterface::getName() #120

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

eliashaeussler
Copy link
Owner

As a follow-up to #119, this PR drops the TypeTransformerInterface::getName() from said interface and its implementations.

@eliashaeussler eliashaeussler added breaking This introduces a breaking change maintenance Code base is being maintained labels Aug 26, 2023
@eliashaeussler eliashaeussler self-assigned this Aug 26, 2023
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.47% 🎉

Comparison is base (786c28e) 93.59% compared to head (799fa5f) 94.06%.

Additional details and impacted files
@@             Coverage Diff              @@
##                1.x     #120      +/-   ##
============================================
+ Coverage     93.59%   94.06%   +0.47%     
+ Complexity      265      263       -2     
============================================
  Files            28       28              
  Lines           796      792       -4     
============================================
  Hits            745      745              
+ Misses           51       47       -4     
Files Changed Coverage Δ
...es/Type/Transformer/FormRequestTypeTransformer.php 100.00% <ø> (+7.14%) ⬆️
...ses/Type/Transformer/FormValuesTypeTransformer.php 100.00% <100.00%> (+8.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eliashaeussler eliashaeussler merged commit af21258 into 1.x Aug 26, 2023
12 checks passed
@eliashaeussler eliashaeussler deleted the task/type-transformer-name branch August 26, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This introduces a breaking change maintenance Code base is being maintained
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant