Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Assure plugin namespace in original request parameters #142

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

eliashaeussler
Copy link
Owner

@eliashaeussler eliashaeussler commented Nov 17, 2023

This PR fixes an issue where the plugin namespace of EXT:form (tx_form_formframework) was not prepended to the uploaded files stored in original request parameters. This bug happened since TYPO3 12.0.0, respectively TYPO3/typo3@02198ea.

Resolves: #138

@eliashaeussler eliashaeussler added the bug Something isn't working label Nov 17, 2023
@eliashaeussler eliashaeussler self-assigned this Nov 17, 2023
Copy link

codeclimate bot commented Nov 17, 2023

Code Climate has analyzed commit d418c11 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c049052) 96.74% compared to head (d418c11) 96.77%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #142      +/-   ##
============================================
+ Coverage     96.74%   96.77%   +0.02%     
- Complexity      258      259       +1     
============================================
  Files            27       27              
  Lines           769      774       +5     
============================================
+ Hits            744      749       +5     
  Misses           25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eliashaeussler eliashaeussler merged commit 435b1df into main Nov 17, 2023
13 checks passed
@eliashaeussler eliashaeussler deleted the fix/plugin-namespace branch November 17, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] After consenting the original form is shown
1 participant