Support for labels with no statement #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 8, 2025 10:26
…qual. Add test corroborating equality of ASTs
eliben
requested changes
Jan 9, 2025
pycparser/c_parser.py
Outdated
| @@ -1580,6 +1580,14 @@ def p_labeled_statement_3(self, p): | |||
| """ labeled_statement : DEFAULT COLON pragmacomp_or_statement """ | |||
| p[0] = c_ast.Default([p[3]], self._token_coord(p, 1)) | |||
|
|
|||
| def p_labeled_statement_4(self, p): | |||
| """ labeled_statement : ID COLON SEMI""" | |||
There was a problem hiding this comment.
I don't think this rule (_4) should be necessary, since a statement can already be empty. Why do you need it?
eliben
requested changes
Jan 10, 2025
There was a problem hiding this comment.
For the test, there's no reason to create a separate class just for this test. You can add a test_ function to the existing class.
Also, you're only checking that the code compiles properly without verifying anything about the AST. pycparser could completely ignore the label here and your test would still pass.
You probably want something similar to test_pragmacomp_or_statement but much simpler, that checks the right AST nodes with labels are parsed in a short function body.
|
Thank you for the all the comments. I imitated the test as you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is aimed at fixing the issue described here: #528
The testing I did seems fine, and I implemented it through two rules to ensure that the representation of
label:andlabel:;is the same.