Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqlite): static jni for sqlite #1006

Merged
merged 1 commit into from
Jun 13, 2024
Merged

fix(sqlite): static jni for sqlite #1006

merged 1 commit into from
Jun 13, 2024

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Jun 13, 2024

Ready for review Powered by Pull Request Badge

Summary

Fixes for SQLite that enable Static JNI access.

Changelog

  • fix: symbol collisions with JNI_OnLoad
  • fix: JNI protocol version at JNI_VERSION_1_8

@sgammon sgammon added bug Something isn't working sqlite Features or issues relating to SQLite support labels Jun 13, 2024
@sgammon sgammon added this to the Release R6: Alpha 10 milestone Jun 13, 2024
@sgammon sgammon requested a review from a team June 13, 2024 07:44
@sgammon sgammon self-assigned this Jun 13, 2024
@sgammon sgammon enabled auto-merge (rebase) June 13, 2024 07:44
@sgammon sgammon mentioned this pull request Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.59%. Comparing base (9b3d37f) to head (5763bd1).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1006   +/-   ##
=======================================
  Coverage   54.59%   54.59%           
=======================================
  Files         320      320           
  Lines       10151    10151           
  Branches     1759     1759           
=======================================
  Hits         5542     5542           
  Misses       4078     4078           
  Partials      531      531           
Flag Coverage Δ
gradle 54.59% <ø> (ø)
jvm 54.59% <ø> (ø)
lib 54.59% <ø> (ø)
plugin 54.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...elide/runtime/gvm/internals/sqlite/SqliteModule.kt 83.49% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 616f63d...5763bd1. Read the comment docs.

- fix: symbol collisions with `JNI_OnLoad`
- fix: JNI protocol version at `JNI_VERSION_1_8`
- fix: don't clash with system `sqlite`

Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon sgammon merged commit df921c9 into main Jun 13, 2024
22 checks passed
@sgammon sgammon deleted the fix/sqlite-static-jni branch June 13, 2024 14:25
This was referenced Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sqlite Features or issues relating to SQLite support
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants