Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: host I/O access using a Hybrid VFS #495

Merged
merged 5 commits into from
Nov 3, 2023
Merged

feat: host I/O access using a Hybrid VFS #495

merged 5 commits into from
Nov 3, 2023

Conversation

darvld
Copy link
Member

@darvld darvld commented Nov 1, 2023

Ready for review Powered by Pull Request Badge

Summary

This PR adds a new experimental "Hybrid" VFS implementation that allows reads to fall back to the host file system if the in-memory bundles cannot satisfy the request. While basic, this implementation unlocks important features:

  • Guest code imports (e.g. require/import) can now be used as long as --host:allow-io is enabled.
  • @intrinsics and related packages are now possible.
  • The fs Node.js intrinsic can finally be implemented thanks to host I/O support.

Closes #463

Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
@darvld darvld added module:graalvm Modules, changes, and issues relating to GraalVM feature Large PRs or issues with full-blown features 🚧 WIP Works-in-progress. Blocks merge 🧪 labs Experimental work vfs Issues and PRs relating to virtual file system (VFS) features module:cli CLI module issues and features labels Nov 1, 2023
@darvld darvld self-assigned this Nov 1, 2023
@github-actions github-actions bot added platform:jvm PRs and issues relating to JVM support. and removed module:graalvm Modules, changes, and issues relating to GraalVM labels Nov 1, 2023
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
@darvld darvld removed the 🚧 WIP Works-in-progress. Blocks merge label Nov 3, 2023
@darvld darvld marked this pull request as ready for review November 3, 2023 19:41
@darvld darvld requested a review from sgammon as a code owner November 3, 2023 19:41
@sgammon sgammon added this to the Release R4: Alpha 8 milestone Nov 3, 2023
@darvld darvld merged commit bf980d3 into main Nov 3, 2023
26 checks passed
@darvld darvld deleted the feat/hybrid-vfs branch November 3, 2023 22:03
@sgammon sgammon mentioned this pull request Apr 18, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Large PRs or issues with full-blown features 🧪 labs Experimental work module:cli CLI module issues and features platform:jvm PRs and issues relating to JVM support. vfs Issues and PRs relating to virtual file system (VFS) features
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Host I/O flag has no effect
2 participants