#38 letter sounds are chosen from TR settings #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jo-elimu
requested changes
May 29, 2017
| @@ -43,6 +43,13 @@ Actor { | |||
| return chosenLetter; | |||
| } | |||
|
|
|||
| function langDir() { | |||
| var l = TR.getCurrentLanguage(); | |||
There was a problem hiding this comment.
@yorugac Don't use one-letter variable names. It's hard to understand. Can you change to for example language?
There was a problem hiding this comment.
Well, yes, but you already merged it? I can change it when I add new images to Orb.qml.
| @@ -43,6 +43,13 @@ Actor { | |||
| return chosenLetter; | |||
| } | |||
|
|
|||
| function langDir() { | |||
| var l = TR.getCurrentLanguage(); | |||
| if(l === "English") return "en"; | |||
There was a problem hiding this comment.
@yorugac Is it normal C++ syntax to put everything on one line instead of two?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.