Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'Human reference sequence assembly version' component from variant observation #36

Closed
rhdolin opened this issue Mar 19, 2021 · 5 comments · Fixed by #53
Closed
Assignees
Labels
good first issue Good for newcomers

Comments

@rhdolin
Copy link
Contributor

rhdolin commented Mar 19, 2021

'Human reference sequence assembly version' can be inferred from RefSeq, and doesn't always apply (e.g. for mitochondrial refSeq's).

@theanmolsharma
Copy link
Contributor

theanmolsharma commented Mar 30, 2021

@srgothi92 I would like to work on this issue. Please guide me.

@rhdolin rhdolin added the good first issue Good for newcomers label Mar 30, 2021
@rhdolin
Copy link
Contributor Author

rhdolin commented Mar 30, 2021

@theanmolsharma Begin by reading the manual to understand high-level how translation works. Then focus on 'create variant observations' section. You'll see that each time the converter creates a FHIR Variant observation, that observation includes a component "LOINC 62374-4 'Human reference sequence assembly version' = GRCh37 or GRCh38, as determined from parameter value". You can see an example of this component by searching this example.

The idea here is to modify the code so that we are no longer creating this component with a variant observation.

@theanmolsharma
Copy link
Contributor

theanmolsharma commented Mar 31, 2021

@rhdolin I think I got what I need to do, I will start working on it right away.
Can you help me identify the function that is generating that component. I think it is here json_generator.py and I need to change the ref_seq. Correct me if I am wrong.

@rhdolin
Copy link
Contributor Author

rhdolin commented Mar 31, 2021

@theanmolsharma Take a look at lines 127-132 in fhir_helper.py to see where this component is getting added.

@theanmolsharma
Copy link
Contributor

@rhdolin I removed the lines that generated that component.

rhdolin added a commit that referenced this issue Apr 7, 2021
Issue #36: Remove 'Human reference sequence assembly version' compone…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants