Fixed FHIR Validation errors and warnings #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed display and codeSystem according to the new balloted specification, and added a DiagnosticReport.category component to fix all the validation errors and warnings
|
I am not well aware of the FHIR specification. @rhdolin Can you help validate the changes in output FHIR by this pull request? |
|
@srgothi92 I reviewed the revisions and I think they look good. Anything else before we merge? |
srgothi92
approved these changes
Jun 16, 2021
rhdolin
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed
displayandcodeSystemaccording to the new balloted specification, and added aDiagnosticReport.categorycomponent to fix all the FHIR validation errors and warnings.How Has This Been Tested?
The code has been tested by running all the unit tests using the command
python -m unittestand validated the PEP 8 formatting usingpycodestyle.