-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to PEP 517 build #80
Conversation
Updated setup.cfg, deleted setup.py and added build time requirements in pyproject.toml to shift the build process to PEP 517.
Can you try deploying the binary to https://test.pypi.org/ and download via pip and confirm everything works without Can you also update |
Hi @srgothi92, |
Can you remove all the changes that you did for this and keep only the changes required for PEP-517 build. |
@srgothi92, actually I made all those changes(like adding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the Readme file also.
Hi @srgothi92, can you please tell what needs to be updated in the |
Sorry, my bad. This PR is ready to be merged. |
Description
Updated
setup.cfg
, deletedsetup.py
, and added build time requirements inpyproject.toml
to shift the build process toPEP 517
.Fixes #18
How Has This Been Tested?
The code has been tested by running all the unit tests using the command
python -m unittest
, validated the PEP 8 formatting usingpycodestyle
and deployed the build topypi
to test if it is installed without any errors usingpip
.package_name