Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

variant inner end error fix and code-system update #98

Merged
merged 1 commit into from
Apr 5, 2022
Merged

variant inner end error fix and code-system update #98

merged 1 commit into from
Apr 5, 2022

Conversation

Rohan-cod
Copy link
Contributor

@Rohan-cod Rohan-cod commented Mar 25, 2022 •
edited
Loading

Description

  • variant inner end should be INFO.END-|INFO.CIEND[0]|
  • component exact-start-end now has a LOINC code 81254-5
  • component inner-start-end now has a LOINC code 81302-2
  • component outer-start-end now has a LOINC code 81301-4
  • component LOINC 81259-4 now has a display of predicted phenotype

How Has This Been Tested?

The code has been tested by running all the unit tests using the command python -m unittest and the PEP 8 formatting was validated using pycodestyle.

  • Unit Tests
  • PEP 8 Formatting Validation

@Rohan-cod
Error fix and code-system update
7b9c94f 
Fixes inner end calculation and updates code-system to the latest LOINC codes.

update 81259-4 display
srgothi92
srgothi92 approved these changes Apr 2, 2022
View reviewed changes
Copy link
Contributor

@srgothi92 srgothi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rhdolin rhdolin merged commit 19f5e48 into elimuinformatics:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhdolin rhdolin rhdolin approved these changes

@srgothi92 srgothi92 srgothi92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rohan-cod @srgothi92 @rhdolin