Skip to content

Commit

Permalink
Get rid of old todos
Browse files Browse the repository at this point in the history
  • Loading branch information
eliotwrobson committed Dec 30, 2024
1 parent 7d46fc1 commit f965880
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 9 deletions.
1 change: 0 additions & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# Automatically publishes version of the package on tagged release
# TODO try to do this so people don't have to build locally: https://github.com/BrianPugh/python-template
name: publish
on:
push:
Expand Down
3 changes: 0 additions & 3 deletions build_package.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
from setuptools.command.build_ext import build_ext
from setuptools.dist import Distribution

# TODO follow this example to make building easier:
# https://github.com/FedericoStra/cython-package-example/blob/master/setup.py


def build_cython_extensions() -> None:
# Flag to enable Cython code generation during install / build. This is
Expand Down
3 changes: 0 additions & 3 deletions tests/test_ic_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -404,9 +404,6 @@ def compute_graph_marginal_gain(
graph: Graph,
new_set_lists: t.List[t.List[int]],
) -> float:
"""
TODO put this function in a shared file.
"""
result = 0.0

new_set = set(item for sublist in new_set_lists for item in sublist)
Expand Down
2 changes: 0 additions & 2 deletions tests/test_lt_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,6 @@ def test_specific_model(directed: bool, nondefault_influence: bool) -> None:
model.reset_model()
model.advance_until_completion()

# TODO this test passes with high-enough probability. Refactor to avoid a possible
# random failure,
assert seen_set != set(model.get_activated_nodes())


Expand Down

0 comments on commit f965880

Please sign in to comment.