Windows fixes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elisemorysc
added a commit
that referenced
this pull request
Nov 13, 2020
* hunter v1.9.5 * remove defaults packages * missing packages * fix matdbg * USe -fno-buildin for GNU and CLANG * update packages * Vulkan: add missing field to VmaVulkanFunctions. * Add subpass parameter type to materials (google#3193) * Fix TypeScript binding for TextureUsage. * Add Dockerfile and test script for SwiftShader. This adds a Dockerfile and a new bash script that makes it east to invoke the appopriate Docker commands. This does not yet enable a GitHub Action because of intermittent issues that we have not yet ironed out. * Add ability to specify post-process material output location (google#3205) * Vulkan: improve the ReadPixels implementation. This adds support for more format conversions and removes a bogus assert that prevented ReadPixels within beginFrame / endFrame. This was tested with: backend_test_mac --api vulkan --gtest_filter=BackendTest.ReadPixels * Allow test_ReadPixels with SwiftShader. * Vulkan: ReadPixels y-flip workaround. * Makes it possible to have multiple instances of ImGuiHelper at the same time This change fixes an issue where ImGuiHelper would crash on destruction if you created more than one instance at the same time. This crash occurred when ImGui::DestroyContext() was called, because when the second instance was destroyed there was no current context causing it to crash. This fixes it by making ImGuiHelper store and manage it's own context. Having two instances of ImGuiHelper is useful in cases where you want to use imgui with multiple views. * Vulkan: fix thread safety regression in Disposer. This fixes a regression introduced by 548b28c manifesting as intermittent assertions. The VulkanDisposer gc() should only be called from the driver thread. * Vulkan: Improve refcounting for vertex buffers. This avoids the following validation error when clients create then immediately destroy vertex buffers, index buffers, and uniform buffers. VUID-vkDestroyBuffer-buffer-00922 Cannot free VkBuffer that is in use by a command buffer. Buffers that are used across multiple frames were fine, but create-and-destroy scenarios were problematic. * Vulkan: fix leak with headless swap chain. * Vulkan: fix destroy-while-used for UBOs. * Fix Windows build. * PlatformVkLinux now supports all combos of XLIB and XCB. You can now build Filament with support for both X11 APIs, or neither. If both are supported, run-time selection is achieved using a SwapChain flag. Supporting only one API at build time (or neither) is useful because our list of "required" VkInstance extensions can vary according to which API's are supported. During VkInstance creation, we do not have a priori knowledge about what kinds of swap chains will be created. (headless vs non-headless, XCB vs XLIB, etc) Note that some Vulkan implementation (e.g. some builds of SwiftShader) only support XCB. * Add PNG output to test_ReadPixels. * Merge duplicated implementations of toLinear(). * Fix iOS build break. * Vulkan: make ReadPixels synchronous. This makes it so that the PixelBufferDescriptor callback triggers at a time consistent with other backends. ReadPixels is still asynchronous in the sense that the callback is triggered on the main thread. However, it is now guaranteed to trigger during (or before) flushAndWait(), which is less surprising behavior. * Vulkan: warn instead of panic for sampler overflow. This makes behavior in release builds similar to the OpenGL backend. In debug builds, we will still assert. * Update RELEASE_NOTES for 1.9.6 * Bump version to 1.9.7 * Update RELEASE_NOTES for 1.9.7 * Version update * update hunter version * add opengl * remove opengl * Windows fixes (#1) * Fix getopt (#2) * fix linux build * fix osx build * civetweb 1.13 * update version * add hunter mat tools flag * remove civetweb from config * revert civetweb * add SPIRV-Tools-opt in config * Update filament-hunter-config.cmake.in * Update filament-hunter-config.cmake.in Co-authored-by: Eli Semory <elisemory@snap.com> Co-authored-by: Philip Rideout <philiprideout@gmail.com> Co-authored-by: Ben Doherty <bendoherty@google.com> Co-authored-by: dsternfeld7 <dsternfeld@google.com> Co-authored-by: Rahul Sheth <rbsheth@cs.stanford.edu> Co-authored-by: Rahul Sheth <rahul@snap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.