Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify hal_apply_direction/1 for pins not activated "in" by simply exporting #119

Merged
merged 1 commit into from
Jul 24, 2022

Conversation

pojiro
Copy link
Contributor

@pojiro pojiro commented Jul 24, 2022

There are pins that have "in" direction after export, but not be activated.
These pins will not become active unless they are overwritten again.
Therefore, modified it to write always.

WHY: not apply this modifying for "out"

Because overwriting "out" has a side effect of changing the GPIO value.

…porting

There are pins that have "in" direction after export, but not be activated.
These pins will not become active unless they are overwritten again.
Therefore, modified it to write always.

WHY: not apply this modifying for "out"

Because overwriting "out" has a side effect of changing the GPIO value.
@pojiro pojiro marked this pull request as ready for review July 24, 2022 12:35
@fhunleth fhunleth merged commit 7e3deb8 into elixir-circuits:main Jul 24, 2022
@fhunleth
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants