Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update FOCA #172

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

build: update FOCA #172

wants to merge 4 commits into from

Conversation

athith-g
Copy link
Contributor

Addresses #171. Version 4.2 is the latest version of the image that runs without errors.

@jvkersch
Copy link

@athith-g What errors do you encounter when you try to update to the latest version of MongoDB? Version 4.2 is also quite old.

@athith-g
Copy link
Contributor Author

@athith-g What errors do you encounter when you try to update to the latest version of MongoDB? Version 4.2 is also quite old.

MongoDB versions 4.4 - 7.0 cause the same error in the protes and protes-worker containers:
pymongo.errors.OperationFailure: ns not found taskStore.tasks

protes-worker traceback:
Screenshot 2024-05-11 at 12 25 58 PM

protes traceback:
Screenshot 2024-05-11 at 12 27 19 PM

@uniqueg
Copy link
Member

uniqueg commented May 11, 2024

@athith-g: Did you try to upgrade pymongo? FOCA currently pins it to 3.10.1 but the latest version is 4.7.2. Unless .drop_indexes() was somehow deprecated in MongoDB, I don't think that this is an issue in FOCA or proTES itself, but rather an incompatibility between the used Mongo client and server versions. If a newer pymongo version works with the more recent MongoDB versino and doesn't cause any other issues, I think we can upgrade it in FOCA.

@athith-g
Copy link
Contributor Author

athith-g commented May 11, 2024

@uniqueg I updated the pymongo version to 4.7.2 and the pymongo errors discussed previously were resolved. The integration tests fail because Collections.insert() is removed in pymongo 4.0+.

Should I make a PR on FOCA to update the pymongo version and then push the new changes (changing insert() to insert_one() and using mongoDB version 7.0) to this branch?

@uniqueg
Copy link
Member

uniqueg commented May 14, 2024

@uniqueg I updated the pymongo version to 4.7.2 and the pymongo errors discussed previously were resolved. The integration tests fail because Collections.insert() is removed in pymongo 4.0+.

Should I make a PR on FOCA to update the pymongo version and then push the new changes (changing insert() to insert_one() and using mongoDB version 7.0) to this branch?

Yes please 🙌

@uniqueg
Copy link
Member

uniqueg commented May 18, 2024

I guess we will need to fix FOCA first, then merge your PR on the FOCA repo, create a release and then I think we need to update the FOCA version in this repo (and during that PR upgrade the MongoDB version in the docker-compose.yml).

So I suppose this is blocked for now, but I have already renamed the PR.

@uniqueg uniqueg marked this pull request as draft May 18, 2024 14:49
@uniqueg uniqueg changed the title Updated mongoDB image version to 4.2 build: update FOCA May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants