Add index storage parameters for Postgres (#578)

elixir-ecto · Nov 28, 2023 · 2d97915 · 2d97915
1 parent d5153e3
commit 2d97915
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/lib/ecto/adapters/postgres/connection.ex b/lib/ecto/adapters/postgres/connection.ex
@@ -1235,6 +1235,7 @@ if Code.ensure_loaded?(Postgrex) do
           ?),
           if_do(include_fields != [], [" INCLUDE ", ?(, include_fields, ?)]),
           maybe_nulls_distinct,
+          if_do(index.options != nil, [" WITH ", ?(, index.options, ?)]),
           if_do(index.where, [" WHERE ", to_string(index.where)])
         ]
       ]

diff --git a/test/ecto/adapters/postgres_test.exs b/test/ecto/adapters/postgres_test.exs
@@ -2694,6 +2694,13 @@ defmodule Ecto.Adapters.PostgresTest do
              [~s|CREATE INDEX "posts_permalink_index" ON ONLY "posts" ("permalink")|]
   end
 
+  test "create an index with storage parameters" do
+    create = {:create, index(:posts, [:title], options: "fillfactor=50")}
+
+    assert execute_ddl(create) ==
+             [~s|CREATE INDEX "posts_title_index" ON "posts" ("title") WITH (fillfactor=50)|]
+  end
+
   test "drop index" do
     drop = {:drop, index(:posts, [:id], name: "posts$main"), :restrict}
     assert execute_ddl(drop) == [~s|DROP INDEX "posts$main"|]