Support :prefix on index rename

[maltoe]

Hi 👋

we wanted to rename an index in a schema on Postgres like the following but the prefix was ignored. This patch adds support for :prefix for Postgres.

rename index(:foo, [:column], prefix: "bar", name: "old"), to: "new"

[maltoe]

The mysql integration test failure appears flaky, dependent on order of selected comments_authors assoc. Would you like me to fix this in this PR?

[edit] nevermind, the test case lives in ecto

[josevalim]

A separate PR is welcome, please!

[maltoe]

A separate PR is welcome, please!

The flaky test already been fixed on Ecto's master elixir-ecto/ecto@ddaa2cf

🤔 It seems the :git dependency on Ecto is cached in the GithubActions workflow and hence isn't always up to date? Maybe deps/ecto should be excluded from the cache?

[josevalim]

We would have to update the lock file, but we did that on main anyway as part of v3.11.0. :)

[maltoe]

We would have to update the lock file, but we did that on main anyway as part of v3.11.0. :)

Right, the lock file is in the cache key, didn't see that.

Not sure I get the rest of your statement though 🙈 - is there anything else I can do for this PR? Are you saying I should update the lock on ecto in this one?

[josevalim]

This PR is good, I am just waiting for a second opinion (who can go ahead and merge it!).

[greg-rychlewski]

Jose I think you may have forgotten to push the 3.11 commit to github for Ecto SQL

[josevalim]

Jose I think you may have forgotten to push the 3.11 commit to github for Ecto SQL

Done!

[greg-rychlewski]

Thanks!