Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dk-remove_comment_sql_injection_validation #713

Closed

Conversation

dkuku
Copy link
Contributor

@dkuku dkuku commented Oct 29, 2024

I think we can remove the check for closing */ in comments, postgres does not allow to have 2 statements sent so a single ; is enough to separate the comment.
This way we don't have to build the string and traverse it. it also enables to use iolists.
In the current implementation it is unnecessary because it's not allowed to send multiple queries, postgres throws an error in this case.

@dkuku
Copy link
Contributor Author

dkuku commented Oct 29, 2024

After thinking about it for longer it may work with postgres but some other databases may actually allow for multiple statements in a single query.

@dkuku dkuku closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant