Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: comment-start-skip. Refs #104, #106, #107 #108

Merged
merged 1 commit into from
Sep 4, 2014

Conversation

sviridov
Copy link
Contributor

@sviridov sviridov commented Sep 4, 2014

Looks like i have fix for issues #104, #106 and three tests from #107.

@mattdeboard
Copy link
Contributor

@sviridov Out of curiosity, how are you executing the tests?

@sviridov
Copy link
Contributor Author

sviridov commented Sep 4, 2014

@mattdeboard With run-tests script. I have Emacs 24.4.50 on my machine and Emacs 24.3.1 in docker container.

@mattdeboard
Copy link
Contributor

Would you be interested in adding docker setup files to the repo? I'm not familiar with Docker at all really, but seems like it would be very useful addition. In a separate PR of course?

@sviridov
Copy link
Contributor Author

sviridov commented Sep 4, 2014

Actually, I don't have any specific configuration for docker. I created new virtual machine (with opensuse in my case) and install emacs (current version in opensuse repo is 24.3.1) into it.

Docker is very simple to start, you can read about it here for example.

@mattdeboard
Copy link
Contributor

Ok, I'm going to get that going before I merge this so I can see the issues for myself. I believe you of course, I just need to take responsibility for supporting stable release of emacs.

@sviridov
Copy link
Contributor Author

sviridov commented Sep 4, 2014

Of course, it's not a problem.

@mattdeboard mattdeboard merged commit 1b30066 into elixir-editors:master Sep 4, 2014
@mattdeboard
Copy link
Contributor

So, I did manage to get a docker container up-and-running, and ran the tests against emacs 24.3.1. There are still 3 test failures as you probably know.

However when I press "Y" to run the tests inside emacs, I get a TON of failures. I don't know if that's just because I'm doing something wrong or what. How did you set up your .emacs inside the container?

@sviridov
Copy link
Contributor Author

sviridov commented Sep 4, 2014

@mattdeboard Actually, I never tried it before. But I did manage to run it.

  • I replaced line 20 of run_scripts with (notice -l ert-bootstrap.el):
emacs -l ert-bootstrap.el -l elixir-mode-tests.el -f ert-run-tests-interactively
  • After that I found that 2 additional tests was failed (related to elixir-quoted-minor-mode) with message (buffer-read-only #<buffer *ert*>). The problem is simple. I will fix it.

@mattdeboard
Copy link
Contributor

💯

@sviridov sviridov deleted the comment-start-skip branch September 5, 2014 08:02
@mattdeboard
Copy link
Contributor

Fixes #104
Fixes #106

J3RN pushed a commit to J3RN/emacs-elixir that referenced this pull request Apr 24, 2021
Hopefully it makes it more obvious that it can take a while
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants