Added: comment-start-skip. Refs #104, #106, #107

[sviridov]

Looks like i have fix for issues #104, #106 and three tests from #107.

[mattdeboard]

@sviridov Out of curiosity, how are you executing the tests?

[sviridov]

@mattdeboard With run-tests script. I have Emacs 24.4.50 on my machine and Emacs 24.3.1 in docker container.

[mattdeboard]

Would you be interested in adding docker setup files to the repo? I'm not familiar with Docker at all really, but seems like it would be very useful addition. In a separate PR of course?

[sviridov]

Actually, I don't have any specific configuration for docker. I created new virtual machine (with opensuse in my case) and install emacs (current version in opensuse repo is 24.3.1) into it.

Docker is very simple to start, you can read about it here for example.

[mattdeboard]

Ok, I'm going to get that going before I merge this so I can see the issues for myself. I believe you of course, I just need to take responsibility for supporting stable release of emacs.

[sviridov]

Of course, it's not a problem.

[mattdeboard]

So, I did manage to get a docker container up-and-running, and ran the tests against emacs 24.3.1. There are still 3 test failures as you probably know.

However when I press "Y" to run the tests inside emacs, I get a TON of failures. I don't know if that's just because I'm doing something wrong or what. How did you set up your .emacs inside the container?

[sviridov]

@mattdeboard Actually, I never tried it before. But I did manage to run it.

• I replaced line 20 of run_scripts with (notice -l ert-bootstrap.el):

emacs -l ert-bootstrap.el -l elixir-mode-tests.el -f ert-run-tests-interactively

• After that I found that 2 additional tests was failed (related to elixir-quoted-minor-mode) with message (buffer-read-only #<buffer *ert*>). The problem is simple. I will fix it.

[mattdeboard]

💯

[mattdeboard]

Fixes #104
Fixes #106