Remove undocumented failing tests. #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the original contributor did not document anything here, and these tests are causing failures, and since contributions to this project have waned significantly, I am removing this test package. If it is deemed necessary or beneficial to have them, please re-add them with documentation.
|
@tonini This one's for you. |
|
Actually I'm going to merginate it myself as this appears to be the source of the travis failures. |
mattdeboard
added a commit
that referenced
this pull request
May 19, 2015
Remove undocumented failing tests.
J3RN
pushed a commit
to J3RN/emacs-elixir
that referenced
this pull request
Apr 24, 2021
…r-editors#186) Rather than throwing an exception (which causes the spawned process to crash) the DocumentSymbols provider will now simply return an error. This is beneficial because this is very much an expected error and thus it is confusing to show the exception in the logs. Possibly there are also performance benefits to this as well. Ideally the DocumentSymbols provider could still return valid symbols in this case, but that is currently infeasible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the original contributor did not document anything here,
and these tests are causing failures, and since contributions to
this project have waned significantly, I am removing this test
package. If it is deemed necessary or beneficial to have them,
please re-add them with documentation.