Properly make variables local #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function make-variable-buffer-local is used for declaring (at the top level) that a certain variable should always be made buffer-local if it is ever changed in any way. For explicitly making a variable buffer-local, especially within a (set ...), one should use make-local-variable, which makes a variable buffer-local for the current buffer. Emacs warns about this during byte-compilation.
antifuchs
added a commit
that referenced
this pull request
Oct 14, 2013
Properly make variables local
|
Good catch, thanks! |
J3RN
pushed a commit
to J3RN/emacs-elixir
that referenced
this pull request
Apr 24, 2021
Add debugger configuration options "env", "startApps", and "excludeMo…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function make-variable-buffer-local is used for declaring (at the
top level) that a certain variable should always be made buffer-local
if it is ever changed in any way. For explicitly making a variable
buffer-local, especially within a (set ...), one should use
make-local-variable, which makes a variable buffer-local for the
current buffer.
Emacs warns about this during byte-compilation.