@typedoc recognized as heredoc #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! Can you add a test just like here? I know the suite is probably broken on many environments but I will see if I can take a look at that later (later this year perhaps...) |
|
@victorolinasc done 👍 |
|
Thanks a lot! @axelson I approve this but I'll leave the merge as your call. Just remember that whatever is on master will be published to MELPA. |
victorolinasc
approved these changes
Jul 22, 2020
|
@axelson I did not bump the version or anything. Not sure the policy here :) |
|
Looks good to me, and it has a test - let's ship it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This fixes #424. This makes
@typedocthat specify a heredoc look just like@docand@moduledoc.Screenshot