You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working with grouped data, I ran across what I believe is an issue. Grouped data doesn't appear to respect the option given to nils:
with_nil=DF.new(%{id: [1,1,1,2,2,2,3,3,3],data: [0.5,1,nil,0.7,1,0.9,0.2,0.2,0.3]})DF.sort_by(with_nil,data,nils: :first)# works as you would expectDF.group_by(with_nil,:id)|>DF.sort_by(data,nils: :last)# nil value is still in the first position
Is this expected behavior, or something worth digging into further?
The text was updated successfully, but these errors were encountered:
* Fix `DF.sort_by/3` with groups to respect `:nils` option
We were using the wrong implementation for the grouped branch.
Close#883
* Improve example to show that sorting works
While working with grouped data, I ran across what I believe is an issue. Grouped data doesn't appear to respect the option given to
nils
:Is this expected behavior, or something worth digging into further?
The text was updated successfully, but these errors were encountered: