Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding of special float values for Series #551

Merged

Conversation

philss
Copy link
Member

@philss philss commented Mar 24, 2023

This commit fixes the encoding of the return of some aggregation functions for the Series module.

We don't have the same problem for expressions because the result of a lazy series evaluation is always a series.

Closes #550

This commit fixes the encoding of the return of some aggregation
functions for the Series module.

We don't have the same problem for expressions because the result of a
lazy series evaluation is always a series.

Closes elixir-explorer#550
@philss
Copy link
Member Author

philss commented Mar 24, 2023

There is a problem I chose not to fix in this PR: the specs of most of the Series are missing the option to return a lazy series. I should fix it after the merge of this PR.

@philss philss requested a review from josevalim March 24, 2023 19:22
@philss philss merged commit ec656f6 into elixir-explorer:main Mar 24, 2023
@philss philss deleted the ps-fix-returning-special-float-values branch March 24, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support returning infinity and nan from aggregation functions
1 participant