Update the way Rust returns errors #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- After this change, all errors returned from Rust will be strings instead of tuples
Jhonatannunessilva
force-pushed
the
update-the-way-rust-returns-errors
branch
from
b1abdd9
to
c52b8ff
Compare
josevalim
reviewed
Jun 18, 2023
| @@ -149,7 +149,7 @@ defmodule Explorer.PolarsBackend.Shared do | |||
| def internal_from_dtype(:integer), do: "i64" | |||
| def internal_from_dtype(:string), do: "str" | |||
|
|
|||
| defp error_message({_err_type, error}) when is_binary(error), do: error | |||
| defp error_message(error) when is_binary(error), do: error | |||
| defp error_message(error), do: inspect(error) | |||
There was a problem hiding this comment.
Will this branch ever be called?
There was a problem hiding this comment.
I don't think so, but if I remove this branch the function will be:
defp error_message(error), do: errorSo is it better to remove it?
There was a problem hiding this comment.
Remove the branch but keep the guard in the previous one?
josevalim
approved these changes
Jun 18, 2023
|
yey! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #584
After this PR, all errors returned from Rust will be strings instead of tuples