Add FSS abstraction to remaining from_* IO functions
#649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactor to avoid exception in case the normalisation does not work.
josevalim
reviewed
Jul 12, 2023
lib/explorer/data_frame.ex
Outdated
|
|
||
| defp normalise_entry(filepath, _config) when is_binary(filepath) do | ||
| if File.exists?(filepath) do | ||
| %Local.Entry{path: filepath} | ||
| {:ok, %Local.Entry{path: filepath}} |
There was a problem hiding this comment.
What if we always return it as %Local.Entry{path: filepath}? Then if it doesn't exist, Polars will fail to read anyway and say the file does not exist. This way we don't need to fiddle with ArgumentError below. Thoughts?
There was a problem hiding this comment.
But you mean, remove the result from the normalise_entry/2 entirely? Or just always return {:ok, %Local.Entry{path: filepath}} for this function clause?
There was a problem hiding this comment.
Don't check if the file exists, alwaus return {:ok, ...} for the function clause.
josevalim
approved these changes
Jul 12, 2023
philss
added a commit
that referenced
this pull request
Jul 24, 2023
* Normalise IO write functions with FSS entry This is similar to #649 * Fix typespecs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #645
PS: I left out the introduction of
endpoint / base_urlto another PR.