Add necessary cargo features #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to avoid building with these features for targets that don't support them.
These features are useful to control which NIF version we are going to compile the project to, and which paths are going to be disabled due to incompatibility with some targets we support. This is using most of the work that is present in philss/rustler-precompiled-action#4 But with an additional "cargo-args" that is experimental.
josevalim
reviewed
Jul 22, 2023
| @@ -54,6 +55,18 @@ pub fn lf_from_parquet_cloud( | |||
| Ok(ExLazyFrame::new(lf)) | |||
| } | |||
|
|
|||
| #[cfg(not(feature = "aws"))] | |||
There was a problem hiding this comment.
Why do we want to have this optional? Some targets do not support it as well?
There was a problem hiding this comment.
Yeah, the problem is that object_store has a dependency - called ring - that has some low-level code in C and Assembly which does not compile for RISCV computers. In my research I found that there were some attempts to fix the issue, but they didn't succeed. I was considering keep a fork and try some patches, but I think that would require some great amount of work.
josevalim
approved these changes
Jul 22, 2023
|
I'm going to merge this one to fix the build, but I should go back to change the version once I release an official version of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These features are useful to control which NIF version we are going to compile
the project to, and which paths are going to be disabled due to incompatibility
with some targets we support.
This is using most of the work that is present in philss/rustler-precompiled-action#4
But with an additional "cargo-args" that is experimental.